Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field_manager interface cleanup #1317

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Field_manager interface cleanup #1317

wants to merge 2 commits into from

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Aug 3, 2023

Description
This PR removes redundant public statements in field_manager_mod and fm_util_mod

Fixes #1244

How Has This Been Tested?
Make successfully runs with Intel and GCC on the AMDBox.
The unit tests for field_manager pass.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

mlee03
mlee03 commented Aug 3, 2023
View reviewed changes
field_manager/fm_util.F90
@@ -102,17 +94,6 @@ module fm_util_mod !{
! Interface definitions for overloaded routines
!

!interface fm_util_get_value !{
Copy link
Contributor Author

@mlee03 mlee03 Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented out interface declaration was removed because the procedures under it do not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

@bensonr bensonr Awaiting requested review from bensonr bensonr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up public interfaces in field_manager_mod and other modules
2 participants
@mlee03 @rem1776